SpriteFramesEditor Fix preview grid in "Select Frames" dialog #52461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YeldhamDev
added
bug
topic:editor
cherrypick:3.3
cherrypick:3.x
akien-mga
approved these changes
Sep 17, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
|
Edit: Undid cherry-pick as it's too much hassle to include all other commits which were needed for this to work, and I don't have bandwidth to actually test that it doesn't regress. |
|
So it's actually too much hassle to backport this fix to I would suggest making a dedicated PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52099 (I'll probably enhance this dialog in another PR, this one is bugfix only).
Fixes #52745.
Cherry-pickable
3.x,3.3.Makes grid being drawn according to the frames this dialog outputs (it allows integer-only frame sizes), scaling/zooming wasn't properly taken into account. Input handling is changed accordingly too. Output frames are unchanged, the preview was broken.
Example:
so the frame size is (64, 64) / (13, 11) = (4, 5)
3.4.beta4:3.x):